From 601cfe3707b1ea777f09695062eee51830320b9a Mon Sep 17 00:00:00 2001 From: Basix Date: Tue, 21 Jan 2020 22:52:28 +0900 Subject: [PATCH] Make webpack detect mode from NODE_ENV --- package.json | 12 ++++++------ webpack.config.js | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 7ac99aa..cad26ef 100644 --- a/package.json +++ b/package.json @@ -8,12 +8,12 @@ "author": "abhijithvijayan <34790378+abhijithvijayan@users.noreply.github.com>", "license": "MIT", "scripts": { - "dev:chrome": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=chrome webpack --watch --mode=development", - "dev:firefox": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=firefox webpack --watch --mode=development", - "dev:opera": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=opera webpack --watch --mode=development", - "build:chrome": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=chrome webpack --mode=production", - "build:firefox": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=firefox webpack --mode=production", - "build:opera": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=opera webpack --mode=production", + "dev:chrome": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=chrome webpack --watch", + "dev:firefox": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=firefox webpack --watch", + "dev:opera": "cross-env NODE_ENV=development cross-env TARGET_BROWSER=opera webpack --watch", + "build:chrome": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=chrome webpack", + "build:firefox": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=firefox webpack", + "build:opera": "cross-env NODE_ENV=production cross-env TARGET_BROWSER=opera webpack ", "build": "yarn run build:chrome && yarn run build:firefox && yarn run build:opera", "lint": "eslint .", "lint:fix": "eslint . --fix" diff --git a/webpack.config.js b/webpack.config.js index 195a96c..1cf1ac7 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -25,7 +25,7 @@ const getExtensionFileType = () => { }; module.exports = { - mode: 'development', + mode: process.env.NODE_ENV === 'production' ? 'production' : 'development', entry: { background: './src/scripts/background.js',