refactor: pass browser as parameter to getExtensionFIleType()

This commit is contained in:
abhijithvijayan 2020-01-23 20:37:41 +05:30
parent 63432e2f60
commit 3541582d21

View File

@ -14,11 +14,11 @@ const manifestInput = require('./src/manifest');
const targetBrowser = process.env.TARGET_BROWSER;
const manifest = wextManifest[targetBrowser](manifestInput);
const getExtensionFileType = () => {
if (targetBrowser === 'opera') {
const getExtensionFileType = browser => {
if (browser === 'opera') {
return 'crx';
}
if (targetBrowser === 'firefox') {
if (browser === 'firefox') {
return 'xpi';
}
return 'zip';
@ -46,7 +46,7 @@ module.exports = {
new CleanWebpackPlugin({
cleanOnceBeforeBuildPatterns: [
path.join(process.cwd(), `extension/${targetBrowser}`),
path.join(process.cwd(), `extension/${targetBrowser}.${getExtensionFileType()}`),
path.join(process.cwd(), `extension/${targetBrowser}.${getExtensionFileType(targetBrowser)}`),
],
cleanStaleWebpackAssets: false,
verbose: true,
@ -128,7 +128,7 @@ module.exports = {
}),
new ZipPlugin({
path: path.resolve(__dirname, 'extension'),
extension: `${getExtensionFileType()}`,
extension: `${getExtensionFileType(targetBrowser)}`,
filename: `${targetBrowser}`,
}),
],