From 2866b4632ac4c581bbdea25ad6651e025edde49f Mon Sep 17 00:00:00 2001 From: Basix Date: Wed, 22 Jan 2020 00:09:16 +0900 Subject: [PATCH] Use pure function --- webpack.config.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/webpack.config.js b/webpack.config.js index 3a28505..9ca80dc 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -10,11 +10,11 @@ const WebextensionPlugin = require('webpack-webextension-plugin'); const targetBrowser = process.env.TARGET_BROWSER; -const getExtensionFileType = () => { - if (targetBrowser === 'opera') { +const getExtensionFileType = browser => { + if (browser === 'opera') { return 'crx'; } - if (targetBrowser === 'firefox') { + if (browser === 'firefox') { return 'xpi'; } return 'zip'; @@ -43,7 +43,7 @@ module.exports = { new CleanWebpackPlugin({ cleanOnceBeforeBuildPatterns: [ path.join(process.cwd(), `extension/${targetBrowser}`), - path.join(process.cwd(), `extension/${targetBrowser}.${getExtensionFileType()}`), + path.join(process.cwd(), `extension/${targetBrowser}.${getExtensionFileType(targetBrowser)}`), ], cleanStaleWebpackAssets: false, verbose: true, @@ -125,7 +125,7 @@ module.exports = { }), new ZipPlugin({ path: path.resolve(__dirname, 'extension'), - extension: `${getExtensionFileType()}`, + extension: `${getExtensionFileType(targetBrowser)}`, filename: `${targetBrowser}`, }), ],