From ff5fc5d63ddb7773449ba69c80ea3daf965be68d Mon Sep 17 00:00:00 2001 From: Zixaphir Date: Mon, 12 Jan 2015 17:33:00 -0700 Subject: [PATCH] Always add a space after generated checkboxes. --- builds/appchan-x.user.js | 17 +++++++++-------- builds/crx/script.js | 17 +++++++++-------- src/General/Header.coffee | 8 ++++---- src/General/UI.coffee | 2 +- src/Monitoring/ThreadUpdater.coffee | 3 ++- src/Monitoring/ThreadWatcher.coffee | 2 +- 6 files changed, 26 insertions(+), 23 deletions(-) diff --git a/builds/appchan-x.user.js b/builds/appchan-x.user.js index 137699e1b..9bdcd66f0 100644 --- a/builds/appchan-x.user.js +++ b/builds/appchan-x.user.js @@ -4386,10 +4386,10 @@ }); box = UI.checkbox; barFixedToggler = box('Fixed Header', 'Fixed Header'); - headerToggler = box('Header auto-hide', ' Auto-hide header'); - scrollHeaderToggler = box('Header auto-hide on scroll', ' Auto-hide header on scroll'); - barPositionToggler = box('Bottom Header', ' Bottom header'); - customNavToggler = box('Custom Board Navigation', ' Custom board navigation'); + headerToggler = box('Header auto-hide', 'Auto-hide header'); + scrollHeaderToggler = box('Header auto-hide on scroll', 'Auto-hide header on scroll'); + barPositionToggler = box('Bottom Header', 'Bottom header'); + customNavToggler = box('Custom Board Navigation', 'Custom board navigation'); editCustomNav = $.el('a', { textContent: 'Edit custom board navigation', href: 'javascript:;' @@ -7264,7 +7264,7 @@ name: name, checked: checked }); - $.add(label, [input, $.tn(text)]); + $.add(label, [input, $.tn(" " + text)]); return label; }; return { @@ -13749,7 +13749,7 @@ ThreadUpdater = { init: function() { - var checked, conf, el, input, name, sc, subEntries, _ref; + var box, checked, conf, el, input, name, sc, subEntries, _ref; if (g.VIEW !== 'thread' || !Conf['Thread Updater']) { return; } @@ -13779,11 +13779,12 @@ $.on(this.timer, 'click', this.update); $.on(this.status, 'click', this.update); subEntries = []; + box = UI.checkbox; _ref = Config.updater.checkbox; for (name in _ref) { conf = _ref[name]; checked = Conf[name] ? 'checked' : ''; - el = UI.checkbox(name, " " + name); + el = box(name, name); input = el.firstElementChild; $.on(input, 'change', $.cb.checked); if (input.name === 'Scroll BG') { @@ -14862,7 +14863,7 @@ var entry, input; entry = { type: 'thread watcher', - el: UI.checkbox(name, " " + name) + el: UI.checkbox(name, name) }; input = entry.el.firstElementChild; $.on(input, 'change', $.cb.checked); diff --git a/builds/crx/script.js b/builds/crx/script.js index e2415c227..33b9de9ca 100644 --- a/builds/crx/script.js +++ b/builds/crx/script.js @@ -4412,10 +4412,10 @@ }); box = UI.checkbox; barFixedToggler = box('Fixed Header', 'Fixed Header'); - headerToggler = box('Header auto-hide', ' Auto-hide header'); - scrollHeaderToggler = box('Header auto-hide on scroll', ' Auto-hide header on scroll'); - barPositionToggler = box('Bottom Header', ' Bottom header'); - customNavToggler = box('Custom Board Navigation', ' Custom board navigation'); + headerToggler = box('Header auto-hide', 'Auto-hide header'); + scrollHeaderToggler = box('Header auto-hide on scroll', 'Auto-hide header on scroll'); + barPositionToggler = box('Bottom Header', 'Bottom header'); + customNavToggler = box('Custom Board Navigation', 'Custom board navigation'); editCustomNav = $.el('a', { textContent: 'Edit custom board navigation', href: 'javascript:;' @@ -7283,7 +7283,7 @@ name: name, checked: checked }); - $.add(label, [input, $.tn(text)]); + $.add(label, [input, $.tn(" " + text)]); return label; }; return { @@ -13773,7 +13773,7 @@ ThreadUpdater = { init: function() { - var checked, conf, el, input, name, sc, subEntries, _ref; + var box, checked, conf, el, input, name, sc, subEntries, _ref; if (g.VIEW !== 'thread' || !Conf['Thread Updater']) { return; } @@ -13803,11 +13803,12 @@ $.on(this.timer, 'click', this.update); $.on(this.status, 'click', this.update); subEntries = []; + box = UI.checkbox; _ref = Config.updater.checkbox; for (name in _ref) { conf = _ref[name]; checked = Conf[name] ? 'checked' : ''; - el = UI.checkbox(name, " " + name); + el = box(name, name); input = el.firstElementChild; $.on(input, 'change', $.cb.checked); if (input.name === 'Scroll BG') { @@ -14886,7 +14887,7 @@ var entry, input; entry = { type: 'thread watcher', - el: UI.checkbox(name, " " + name) + el: UI.checkbox(name, name) }; input = entry.el.firstElementChild; $.on(input, 'change', $.cb.checked); diff --git a/src/General/Header.coffee b/src/General/Header.coffee index 8ec869f0c..22c2f68ce 100644 --- a/src/General/Header.coffee +++ b/src/General/Header.coffee @@ -9,10 +9,10 @@ Header = box = UI.checkbox barFixedToggler = box 'Fixed Header', 'Fixed Header' - headerToggler = box 'Header auto-hide', ' Auto-hide header' - scrollHeaderToggler = box 'Header auto-hide on scroll', ' Auto-hide header on scroll' - barPositionToggler = box 'Bottom Header', ' Bottom header' - customNavToggler = box 'Custom Board Navigation', ' Custom board navigation' + headerToggler = box 'Header auto-hide', 'Auto-hide header' + scrollHeaderToggler = box 'Header auto-hide on scroll', 'Auto-hide header on scroll' + barPositionToggler = box 'Bottom Header', 'Bottom header' + customNavToggler = box 'Custom Board Navigation', 'Custom board navigation' editCustomNav = $.el 'a', textContent: 'Edit custom board navigation' diff --git a/src/General/UI.coffee b/src/General/UI.coffee index d2f50334e..07635b8f5 100755 --- a/src/General/UI.coffee +++ b/src/General/UI.coffee @@ -379,7 +379,7 @@ UI = do -> checked = Conf[name] unless checked? label = $.el 'label' input = $.el 'input', {type: 'checkbox', name, checked} - $.add label, [input, $.tn text] + $.add label, [input, $.tn " #{text}"] label return { diff --git a/src/Monitoring/ThreadUpdater.coffee b/src/Monitoring/ThreadUpdater.coffee index 03911d010..7d4cec7d0 100755 --- a/src/Monitoring/ThreadUpdater.coffee +++ b/src/Monitoring/ThreadUpdater.coffee @@ -25,9 +25,10 @@ ThreadUpdater = $.on @status, 'click', @update subEntries = [] + box = UI.checkbox for name, conf of Config.updater.checkbox checked = if Conf[name] then 'checked' else '' - el = UI.checkbox name, " #{name}" + el = box name, name input = el.firstElementChild $.on input, 'change', $.cb.checked if input.name is 'Scroll BG' diff --git a/src/Monitoring/ThreadWatcher.coffee b/src/Monitoring/ThreadWatcher.coffee index b95a7b5a9..afd8258d8 100755 --- a/src/Monitoring/ThreadWatcher.coffee +++ b/src/Monitoring/ThreadWatcher.coffee @@ -401,7 +401,7 @@ ThreadWatcher = createSubEntry: (name, desc) -> entry = type: 'thread watcher' - el: UI.checkbox name, " #{name}" + el: UI.checkbox name, name input = entry.el.firstElementChild $.on input, 'change', $.cb.checked $.on input, 'change', ThreadWatcher.refresh if name in ['Current Board', 'Show Unread Count']