From e952e0de27136d2af4a6ca4471fe2e161c90ade5 Mon Sep 17 00:00:00 2001 From: Mayhem Date: Tue, 14 May 2013 22:24:37 +0200 Subject: [PATCH 1/5] Some obscure issue where #boardNavDesktop is missing, investigating it. It represents 15% of error reports. --- src/General/Header.coffee | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/src/General/Header.coffee b/src/General/Header.coffee index c2fa2dccb..f374cbb67 100644 --- a/src/General/Header.coffee +++ b/src/General/Header.coffee @@ -89,13 +89,26 @@ Header = if a = $ "a[href*='/#{g.BOARD}/']", nav a.className = 'current' fullBoardList = $ '#full-board-list', Header.bar - fullBoardList.innerHTML = nav.innerHTML - $.rm $ '#navtopright', fullBoardList - btn = $.el 'span', - className: 'hide-board-list-button brackets-wrap' - innerHTML: ' - ' - $.on btn, 'click', Header.toggleBoardList - $.add fullBoardList, btn + # XXX Getting weird reports here of + # "Header" initialization crashed. TypeError: Cannot read property 'innerHTML' of null + # Let's try to find the cause. + if nav is null + Main.logError + message: "Header crash: nav is null" + error: new Error """ + #{!!$.id 'boardNavMobile'} + d.readyState = #{d.readyState} + doc.className = #{doc.className} + d.body.className = #{d.body.className} + """ + else + fullBoardList.innerHTML = nav.innerHTML + $.rm $ '#navtopright', fullBoardList + btn = $.el 'span', + className: 'hide-board-list-button brackets-wrap' + innerHTML: ' - ' + $.on btn, 'click', Header.toggleBoardList + $.add fullBoardList, btn Header.setCustomNav Conf['Custom Board Navigation'] Header.generateBoardList Conf['boardnav'] From e55a05cf05f52dce4d3dbd55a2094406664fcd8d Mon Sep 17 00:00:00 2001 From: Mayhem Date: Tue, 14 May 2013 22:42:51 +0200 Subject: [PATCH 2/5] Make the QR thread selector appear as a clickable link. --- css/burichan.css | 6 ++++++ css/futaba.css | 6 ++++++ css/photon.css | 8 +++++++- css/style.css | 4 ++++ css/tomorrow.css | 12 ++++++------ css/yotsuba-b.css | 6 ++++++ css/yotsuba.css | 6 ++++++ 7 files changed, 41 insertions(+), 7 deletions(-) diff --git a/css/burichan.css b/css/burichan.css index 0c941526c..ac1dc8ba7 100644 --- a/css/burichan.css +++ b/css/burichan.css @@ -31,6 +31,12 @@ } /* QR */ +:root.burichan #qr select { + color: #34345C; +} +:root.burichan #qr select:hover { + color: #DD0000; +} .burichan #dump-list::-webkit-scrollbar-thumb { background-color: #D6DAF0; border-color: #B7C5D9; diff --git a/css/futaba.css b/css/futaba.css index 30099ef0c..0f21afb04 100644 --- a/css/futaba.css +++ b/css/futaba.css @@ -31,6 +31,12 @@ } /* QR */ +:root.futaba #qr select { + color: #00E; +} +:root.futaba #qr select:hover { + color: red; +} .futaba #dump-list::-webkit-scrollbar-thumb { background-color: #F0E0D6; border-color: #D9BFB7; diff --git a/css/photon.css b/css/photon.css index cd4d9a702..2580b0cf2 100644 --- a/css/photon.css +++ b/css/photon.css @@ -13,7 +13,7 @@ color: #333; } :root.photon #header-bar a { - color: #FF6600; + color: #F60; } /* Settings */ @@ -31,6 +31,12 @@ } /* QR */ +:root.photon #qr select { + color: #F60; +} +:root.photon #qr select:hover { + color: #FF3300; +} .photon #dump-list::-webkit-scrollbar-thumb { background-color: #DDD; border-color: #CCC; diff --git a/css/style.css b/css/style.css index 520faec69..d53f3b960 100644 --- a/css/style.css +++ b/css/style.css @@ -606,6 +606,10 @@ a.hide-announcement { border: none; background: none; } +#qr option { + color: #000; + background-color: #F7F7F7; +} .presto #qr select { height: 1em; } diff --git a/css/tomorrow.css b/css/tomorrow.css index 2d03d4498..e14ed417a 100644 --- a/css/tomorrow.css +++ b/css/tomorrow.css @@ -31,16 +31,16 @@ } /* QR */ +:root.tomorrow #qr select { + color: #81A2BE; +} +:root.tomorrow #qr select:hover { + color: #5F89AC; +} .tomorrow #dump-list::-webkit-scrollbar-thumb { background-color: #282A2E; border-color: #111; } -:root.tomorrow #qr select { - color: #C5C8C6; -} -:root.tomorrow #qr option { - color: #000; -} :root.tomorrow .qr-preview { background-color: rgba(255, 255, 255, .15); } diff --git a/css/yotsuba-b.css b/css/yotsuba-b.css index 20b1214fe..a39555c47 100644 --- a/css/yotsuba-b.css +++ b/css/yotsuba-b.css @@ -31,6 +31,12 @@ } /* QR */ +:root.yotsuba-b #qr select { + color: #34345C; +} +:root.yotsuba-b #qr select:hover { + color: #DD0000; +} .yotsuba-b #dump-list::-webkit-scrollbar-thumb { background-color: #D6DAF0; border-color: #B7C5D9; diff --git a/css/yotsuba.css b/css/yotsuba.css index 2cf8b83ba..5bb2e187b 100644 --- a/css/yotsuba.css +++ b/css/yotsuba.css @@ -31,6 +31,12 @@ } /* QR */ +:root.yotsuba #qr select { + color: #00E; +} +:root.yotsuba #qr select:hover { + color: red; +} .yotsuba #dump-list::-webkit-scrollbar-thumb { background-color: #F0E0D6; border-color: #D9BFB7; From fe30a3f2b3d731387bdccfd955582e4a779fe04d Mon Sep 17 00:00:00 2001 From: Mayhem Date: Tue, 14 May 2013 22:46:01 +0200 Subject: [PATCH 3/5] Close #1101. --- src/Posting/QR.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Posting/QR.coffee b/src/Posting/QR.coffee index d6bb1d39b..5bca535b6 100644 --- a/src/Posting/QR.coffee +++ b/src/Posting/QR.coffee @@ -949,13 +949,13 @@ QR = {challenge, response} = QR.captcha.getOne() err = 'No valid captcha.' unless response + QR.cleanNotifications() if err # stop auto-posting QR.cooldown.auto = false QR.status() QR.error err return - QR.cleanNotifications() # Enable auto-posting if we have stuff to post, disable it otherwise. QR.cooldown.auto = QR.posts.length > 1 From 0588d2b87612628c938533d60fe004ac64340502 Mon Sep 17 00:00:00 2001 From: Mayhem Date: Tue, 14 May 2013 22:46:18 +0200 Subject: [PATCH 4/5] Release 4chan X v3.4.2. --- CHANGELOG.md | 2 ++ package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 23c1cc93a..e88290a58 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,5 @@ +### 3.4.2 - *2013-05-14* + ### 3.4.1 - *2013-05-13* - Added a button in the Archives settings to update the list now. diff --git a/package.json b/package.json index f719b466e..2013a2ae4 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "4chan-X", - "version": "3.4.1", + "version": "3.4.2", "description": "Cross-browser extension for productive lurking on 4chan.", "meta": { "name": "4chan X", From 81fe12d40eba45fca48e23dcc896cf515227e498 Mon Sep 17 00:00:00 2001 From: Mayhem Date: Tue, 14 May 2013 22:47:53 +0200 Subject: [PATCH 5/5] Changelog for v3.4.2. --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e88290a58..2e10a9a5b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ ### 3.4.2 - *2013-05-14* +- Minor fixes. + ### 3.4.1 - *2013-05-13* - Added a button in the Archives settings to update the list now.