From d1248421bc6c244b6d0b57bdf199eede76a1d939 Mon Sep 17 00:00:00 2001 From: Nicolas Stepien Date: Thu, 18 Apr 2013 16:07:58 +0200 Subject: [PATCH] Thought I'd update the contributing guidelines. --- CONTRIBUTING.md | 9 ++++++++- src/features.coffee | 5 ++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 685ca0727..460cfb6db 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,6 @@ -## Reporting bugs +## Reporting bugs and suggestions +Reporting bugs: 1. Make sure both your **browser** and **4chan X** are up to date. 2. Disable your other extensions & scripts to identify conflicts. 3. If your issue persists, open a [new issue](https://github.com/MayhemYDG/4chan-x/issues) with the following information: @@ -13,6 +14,12 @@ Open your console with: - `Ctrl + Shift + K` on Firefox. - `Ctrl + Shift + O` on Opera. +Respect these guidelines: +- Describe the issue clearly, put some effort into it. A one-liner isn't a good enough description. +- If you to get your suggestion implemented sooner, make it convincing. +- If you want to criticize, make it convincing and constructive. +- Be mature. Act like an idiot and you will be blocked without warning. + ## Development & Contribution ### Get started diff --git a/src/features.coffee b/src/features.coffee index 4a4bfb427..f731c64bf 100644 --- a/src/features.coffee +++ b/src/features.coffee @@ -299,7 +299,7 @@ Settings =
<%= meta.name %> | #{g.VERSION} | - Issues | + Issues | ×
@@ -804,8 +804,7 @@ PSAHiding = toggle: (e) -> hide = $.hasClass @, 'hide-announcement' text = PSAHiding.trim $.id 'globalMessage' - $.get 'hiddenPSAs', [], (item) -> - {hiddenPSAs} = item + $.get 'hiddenPSAs', [], ({hiddenPSAs}) -> if hide hiddenPSAs.push text else