Goyslop/4chan-x
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

I like proper error messages.

Browse Source
This commit is contained in:
Zixaphir 2015-01-13 12:03:14 -07:00
parent f6ac531b16
commit cc9cfd9467
4 changed files with 14 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
builds/appchan-x.user.js
View File

@ -18807,15 +18807,10 @@
return Navigate.parse(req.response.posts); return Navigate.parse(req.response.posts);
} catch (_error) { } catch (_error) {
err = _error; err = _error;
console.error('Navigate failure:'); return Main.handleErrors({
console.log(err); message: "Navigate Failure.",
if (notice) { error: err
notice.setType('error'); });
notice.el.lastElementChild.textContent = 'Navigation Failed.';
setTimeout(notice.close, 2 * $.SECOND);
} else {
new Notice('error', 'Navigation Failed.', 2);
}
} }
}, },
makeBreadCrumb: function(href, view, boardID, threadID) { makeBreadCrumb: function(href, view, boardID, threadID) {
@ -20328,7 +20323,7 @@
}, },
parseError: function(data) { parseError: function(data) {
var error, message; var error, message;
c.error(data.message, data.error.stack); c.error(data.message, data.error.message, data.error.stack);
message = $.el('div', { message = $.el('div', {
textContent: data.message textContent: data.message
}); });

15
builds/crx/script.js
View File

@ -18833,15 +18833,10 @@
return Navigate.parse(req.response.posts); return Navigate.parse(req.response.posts);
} catch (_error) { } catch (_error) {
err = _error; err = _error;
console.error('Navigate failure:'); return Main.handleErrors({
console.log(err); message: "Navigate Failure.",
if (notice) { error: err
notice.setType('error'); });
notice.el.lastElementChild.textContent = 'Navigation Failed.';
setTimeout(notice.close, 2 * $.SECOND);
} else {
new Notice('error', 'Navigation Failed.', 2);
}
} }
}, },
makeBreadCrumb: function(href, view, boardID, threadID) { makeBreadCrumb: function(href, view, boardID, threadID) {
@ -20334,7 +20329,7 @@
}, },
parseError: function(data) { parseError: function(data) {
var error, message; var error, message;
c.error(data.message, data.error.stack); c.error(data.message, data.error.message, data.error.stack);
message = $.el('div', { message = $.el('div', {
textContent: data.message textContent: data.message
}); });

2
src/General/Main.coffee
View File

@ -241,7 +241,7 @@ Main =
new Notice 'error', [div, logs], 30 new Notice 'error', [div, logs], 30
parseError: (data) -> parseError: (data) ->
c.error data.message, data.error.stack c.error data.message, data.error.message, data.error.stack
message = $.el 'div', message = $.el 'div',
textContent: data.message textContent: data.message
error = $.el 'div', error = $.el 'div',

13
src/General/Navigate.coffee
View File

@ -304,16 +304,9 @@ Navigate =
try try
Navigate.parse req.response.posts Navigate.parse req.response.posts
catch err catch err
console.error 'Navigate failure:' Main.handleErrors
console.log err message: "Navigate Failure."
# network error or non-JSON content for example. error: err
if notice
notice.setType 'error'
notice.el.lastElementChild.textContent = 'Navigation Failed.'
setTimeout notice.close, 2 * $.SECOND
else
new Notice 'error', 'Navigation Failed.', 2
return
makeBreadCrumb: (href, view, boardID, threadID) -> makeBreadCrumb: (href, view, boardID, threadID) ->
breadCrumb = $.el 'span', breadCrumb = $.el 'span',