From aafae54e176f3fac5e72e1729a2cf4cf66c17bf0 Mon Sep 17 00:00:00 2001 From: Nicolas Stepien Date: Mon, 25 Feb 2013 20:55:31 +0100 Subject: [PATCH] Array::slice.call x -> [x...] --- 4chan_x.user.js | 15 ++++++++------- lib/$.coffee | 2 +- lib/ui.coffee | 2 +- src/features.coffee | 7 +++---- src/qr.coffee | 4 ++-- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/4chan_x.user.js b/4chan_x.user.js index 34a279d01..c0ba7b540 100644 --- a/4chan_x.user.js +++ b/4chan_x.user.js @@ -44,6 +44,7 @@ (function() { var $, $$, Anonymize, ArchiveLink, AutoGIF, Board, Build, Clone, Conf, Config, DeleteLink, DownloadLink, ExpandComment, ExpandThread, Favicon, FileInfo, Filter, Fourchan, Get, Header, ImageExpand, ImageHover, Keybinds, Main, Menu, Misc, Nav, Notification, Polyfill, Post, QR, QuoteBacklink, QuoteCT, QuoteInline, QuoteOP, QuotePreview, QuoteYou, Quotify, Recursive, Redirect, RelativeDates, ReplyHiding, ReportLink, RevealSpoilers, Sauce, Settings, Thread, ThreadExcerpt, ThreadHiding, ThreadStats, ThreadUpdater, ThreadWatcher, Time, UI, Unread, d, doc, g, + __slice = [].slice, __indexOf = [].indexOf || function(item) { for (var i = 0, l = this.length; i < l; i++) { if (i in this && this[i] === item) return i; } return -1; }, __hasProp = {}.hasOwnProperty, __extends = function(child, parent) { for (var key in parent) { if (__hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; }; @@ -323,7 +324,7 @@ Menu.prototype.findNextEntry = function(entry, direction) { var entries; - entries = Array.prototype.slice.call(entry.parentNode.children); + entries = __slice.call(entry.parentNode.children); entries.sort(function(first, second) { return +(first.style.order || first.style.webkitOrder) - +(second.style.order || second.style.webkitOrder); }); @@ -611,7 +612,7 @@ if (root == null) { root = d.body; } - return Array.prototype.slice.call(root.querySelectorAll(selector)); + return __slice.call(root.querySelectorAll(selector)); }; $.extend = function(object, properties) { @@ -1059,7 +1060,7 @@ a.className = 'current'; $('.board-title', Header.headerEl).textContent = a.title; } - return $.add($('.board-list', Header.headerEl), Array.prototype.slice.call(nav.childNodes)); + return $.add($('.board-list', Header.headerEl), __slice.call(nav.childNodes)); } }, toggleBoardList: function() { @@ -3353,7 +3354,7 @@ _ref4 = [quotedPost].concat(quotedPost.clones); for (_k = 0, _len2 = _ref4.length; _k < _len2; _k++) { quotedPost = _ref4[_k]; - quotelinks.push.apply(quotelinks, Array.prototype.slice.call(quotedPost.nodes.backlinks)); + quotelinks.push.apply(quotelinks, __slice.call(quotedPost.nodes.backlinks)); } } } @@ -3590,7 +3591,7 @@ for (_i = 0, _len = _ref.length; _i < _len; _i++) { deadlink = _ref[_i]; if (deadlink.parentNode.className === 'prettyprint') { - $.replace(deadlink, Array.prototype.slice.call(deadlink.childNodes)); + $.replace(deadlink, __slice.call(deadlink.childNodes)); continue; } quote = deadlink.textContent; @@ -5981,7 +5982,7 @@ fileInput: function(files) { var file, length, max, _i, _len, _ref, _ref1; if (!(files instanceof FileList)) { - files = Array.prototype.slice.call(this.files); + files = __slice.call(this.files); } QR.nodes.fileInput.value = null; length = files.length; @@ -6234,7 +6235,7 @@ var el, index, newIndex, oldIndex, reply; el = $('.drag', this.parentNode); index = function(el) { - return Array.prototype.slice.call(el.parentNode.children).indexOf(el); + return __slice.call(el.parentNode.children).indexOf(el); }; oldIndex = index(el); newIndex = index(this); diff --git a/lib/$.coffee b/lib/$.coffee index a6b3d7862..faf80192c 100644 --- a/lib/$.coffee +++ b/lib/$.coffee @@ -4,7 +4,7 @@ $ = (selector, root=d.body) -> root.querySelector selector $$ = (selector, root=d.body) -> - Array::slice.call root.querySelectorAll selector + [root.querySelectorAll(selector)...] $.extend = (object, properties) -> for key, val of properties diff --git a/lib/ui.coffee b/lib/ui.coffee index dc96b0006..517bc3965 100644 --- a/lib/ui.coffee +++ b/lib/ui.coffee @@ -107,7 +107,7 @@ UI = do -> $.off d, 'CloseMenu', @close findNextEntry: (entry, direction) -> - entries = Array::slice.call entry.parentNode.children + entries = [entry.parentNode.children...] entries.sort (first, second) -> +(first.style.order or first.style.webkitOrder) - +(second.style.order or second.style.webkitOrder) entries[entries.indexOf(entry) + direction] diff --git a/src/features.coffee b/src/features.coffee index 354f3da84..51442e76c 100644 --- a/src/features.coffee +++ b/src/features.coffee @@ -57,8 +57,7 @@ Header = if a = $ "a[href*='/#{g.BOARD}/']", nav a.className = 'current' $('.board-title', Header.headerEl).textContent = a.title - $.add $('.board-list', Header.headerEl), - Array::slice.call nav.childNodes + $.add $('.board-list', Header.headerEl), [nav.childNodes...] toggleBoardList: -> node = @firstElementChild.firstChild @@ -2073,7 +2072,7 @@ Get = for quote in post.quotes continue unless quotedPost = g.posts[quote] for quotedPost in [quotedPost].concat quotedPost.clones - quotelinks.push.apply quotelinks, Array::slice.call quotedPost.nodes.backlinks + quotelinks.push.apply quotelinks, [quotedPost.nodes.backlinks...] # Third: # Filter out irrelevant quotelinks. quotelinks.filter (quotelink) -> @@ -2287,7 +2286,7 @@ Quotify = if deadlink.parentNode.className is 'prettyprint' # Don't quotify deadlinks inside code tags, # un-`span` them. - $.replace deadlink, Array::slice.call deadlink.childNodes + $.replace deadlink, [deadlink.childNodes...] continue quote = deadlink.textContent diff --git a/src/qr.coffee b/src/qr.coffee index 942601203..d4c0b765f 100644 --- a/src/qr.coffee +++ b/src/qr.coffee @@ -291,7 +291,7 @@ QR = $.addClass QR.nodes.el, 'dump' fileInput: (files) -> unless files instanceof FileList - files = Array::slice.call @files + files = [@files...] QR.nodes.fileInput.value = null # Don't hold the files from being modified on windows {length} = files return unless length @@ -482,7 +482,7 @@ QR = e.dataTransfer.dropEffect = 'move' drop: -> el = $ '.drag', @parentNode - index = (el) -> Array::slice.call(el.parentNode.children).indexOf el + index = (el) -> [el.parentNode.children...].indexOf el oldIndex = index el newIndex = index @ $.rmClass el, 'drag' # Opera doesn't fire dragEnd if we drop it on something else