Goyslop/4chan-x
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bind once, don't unbind (unnecessary)

Browse Source
This commit is contained in:
James Campos 2011-05-07 19:07:15 -07:00
parent 1a9a62f868
commit 5b58ae91bb
2 changed files with 14 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
4chan_x.js
View File

@ -1672,7 +1672,9 @@
_results = []; _results = [];
for (_i = 0, _len = quotes.length; _i < _len; _i++) { for (_i = 0, _len = quotes.length; _i < _len; _i++) {
quote = quotes[_i]; quote = quotes[_i];
_results.push($.bind(quote, 'mouseover', quotePreview.mouseover)); $.bind(quote, 'mouseover', quotePreview.mouseover);
$.bind(quote, 'mousemove', quotePreview.mousemove);
_results.push($.bind(quote, 'mouseout', quotePreview.mouseout));
} }
return _results; return _results;
}, },
@ -1682,9 +1684,7 @@
preview = $('#qp'); preview = $('#qp');
id = target.textContent.replace(">>", ''); id = target.textContent.replace(">>", '');
preview.innerHTML = d.getElementById(id).innerHTML; preview.innerHTML = d.getElementById(id).innerHTML;
$.show(preview); return $.show(preview);
$.bind(target, 'mousemove', quotePreview.mousemove);
return $.bind(target, 'mouseout', quotePreview.mouseout);
}, },
mousemove: function(e) { mousemove: function(e) {
var clientX, clientY, preview; var clientX, clientY, preview;
@ -1697,9 +1697,7 @@
var preview, target; var preview, target;
target = e.target; target = e.target;
preview = $('#qp'); preview = $('#qp');
$.hide(preview); return $.hide(preview);
$.unbind(target, 'mousemove', quotePreview.mousemove);
return $.unbind(target, 'mouseout', quotePreview.mouseout);
} }
}; };
quickReport = { quickReport = {
@ -1900,7 +1898,9 @@
_results = []; _results = [];
for (_i = 0, _len = thumbs.length; _i < _len; _i++) { for (_i = 0, _len = thumbs.length; _i < _len; _i++) {
thumb = thumbs[_i]; thumb = thumbs[_i];
_results.push($.bind(thumb, 'mouseover', imageHover.cb.mouseover)); $.bind(thumb, 'mouseover', imageHover.cb.mouseover);
$.bind(thumb, 'mousemove', imageHover.cb.mousemove);
_results.push($.bind(thumb, 'mouseout', imageHover.cb.mouseout));
} }
return _results; return _results;
}, },
@ -1911,9 +1911,7 @@
img.src = target.parentNode.href; img.src = target.parentNode.href;
$.show(img); $.show(img);
imageHover.winHeight = d.body.clientHeight; imageHover.winHeight = d.body.clientHeight;
imageHover.winWidth = d.body.clientWidth; return imageHover.winWidth = d.body.clientWidth;
$.bind(target, 'mousemove', imageHover.cb.mousemove);
return $.bind(target, 'mouseout', imageHover.cb.mouseout);
}, },
mousemove: function(e) { mousemove: function(e) {
var bot, clientX, clientY, img, imgHeight, top; var bot, clientX, clientY, img, imgHeight, top;
@ -1930,9 +1928,7 @@
target = e.target; target = e.target;
img = $('#iHover'); img = $('#iHover');
$.hide(img); $.hide(img);
img.src = null; return img.src = null;
$.unbind(target, 'mousemove', imageHover.cb.mousemove);
return $.unbind(target, 'mouseout', imageHover.cb.mouseout);
} }
} }
}; };

12
script.coffee
View File

@ -1328,14 +1328,14 @@ quotePreview =
quotes = $$ 'a.quotelink' quotes = $$ 'a.quotelink'
for quote in quotes for quote in quotes
$.bind quote, 'mouseover', quotePreview.mouseover $.bind quote, 'mouseover', quotePreview.mouseover
$.bind quote, 'mousemove', quotePreview.mousemove
$.bind quote, 'mouseout', quotePreview.mouseout
mouseover: (e) -> mouseover: (e) ->
{target, clientX, clientY} = e {target, clientX, clientY} = e
preview = $ '#qp' preview = $ '#qp'
id = target.textContent.replace ">>", '' id = target.textContent.replace ">>", ''
preview.innerHTML = d.getElementById(id).innerHTML preview.innerHTML = d.getElementById(id).innerHTML
$.show preview $.show preview
$.bind target, 'mousemove', quotePreview.mousemove
$.bind target, 'mouseout', quotePreview.mouseout
mousemove: (e) -> mousemove: (e) ->
{clientX, clientY} = e {clientX, clientY} = e
preview = $ '#qp' preview = $ '#qp'
@ -1345,8 +1345,6 @@ quotePreview =
{target} = e {target} = e
preview = $ '#qp' preview = $ '#qp'
$.hide preview $.hide preview
$.unbind target, 'mousemove', quotePreview.mousemove
$.unbind target, 'mouseout', quotePreview.mouseout
quickReport = quickReport =
init: -> init: ->
@ -1472,6 +1470,8 @@ imageHover =
thumbs = $$ 'img[md5]', root thumbs = $$ 'img[md5]', root
for thumb in thumbs for thumb in thumbs
$.bind thumb, 'mouseover', imageHover.cb.mouseover $.bind thumb, 'mouseover', imageHover.cb.mouseover
$.bind thumb, 'mousemove', imageHover.cb.mousemove
$.bind thumb, 'mouseout', imageHover.cb.mouseout
mouseover: (e) -> mouseover: (e) ->
{target, clientX, clientY} = e {target, clientX, clientY} = e
img = $ '#iHover' img = $ '#iHover'
@ -1479,8 +1479,6 @@ imageHover =
$.show img $.show img
imageHover.winHeight = d.body.clientHeight imageHover.winHeight = d.body.clientHeight
imageHover.winWidth = d.body.clientWidth imageHover.winWidth = d.body.clientWidth
$.bind target, 'mousemove', imageHover.cb.mousemove
$.bind target, 'mouseout', imageHover.cb.mouseout
mousemove: (e) -> mousemove: (e) ->
{clientX, clientY} = e {clientX, clientY} = e
img = $ '#iHover' img = $ '#iHover'
@ -1501,8 +1499,6 @@ imageHover =
img = $ '#iHover' img = $ '#iHover'
$.hide img $.hide img
img.src = null img.src = null
$.unbind target, 'mousemove', imageHover.cb.mousemove
$.unbind target, 'mouseout', imageHover.cb.mouseout
imgPreloading = imgPreloading =
init: -> init: ->