From 388c8b9d1a152777f7dd1c27925f9d79018977e2 Mon Sep 17 00:00:00 2001 From: Mayhem Date: Mon, 20 May 2013 02:46:05 +0200 Subject: [PATCH] Fix withCredentials on synchronous XHRs. --- lib/$.coffee | 9 ++++++++- src/Monitoring/Unread.coffee | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/$.coffee b/lib/$.coffee index c255c13f8..a37a9c494 100644 --- a/lib/$.coffee +++ b/lib/$.coffee @@ -46,7 +46,14 @@ $.ajax = (url, callbacks, opts={}) -> r.setRequestHeader key, val $.extend r, callbacks $.extend r.upload, upCallbacks - r.withCredentials = cred + try + # Firefox throws an error if you try + # to set this on a synchronous XHR. + # Only cookies from the remote domain + # are used in a request withCredentials. + r.withCredentials = cred + catch err + # do nothing r.send form r $.cache = do -> diff --git a/src/Monitoring/Unread.coffee b/src/Monitoring/Unread.coffee index 79a4f072b..a951be09a 100644 --- a/src/Monitoring/Unread.coffee +++ b/src/Monitoring/Unread.coffee @@ -131,7 +131,7 @@ Unread = Unread.db.set boardID: Unread.thread.board.ID threadID: Unread.thread.ID - val: Unread.lastReadPost + val: Unread.lastReadPost setLine: (force) -> return unless d.hidden or force is true