Goyslop/4chan-x
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't scroll back when contracting an image if the image isn't partially visible. Close #859

Browse Source
This commit is contained in:
Nicolas Stepien 2012-12-16 12:22:47 +01:00
parent 763311f7dd
commit 363ea695d7
2 changed files with 24 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
4chan_x.user.js
View File

@ -5094,19 +5094,21 @@
thumb = a.firstChild;
if (thumb.hidden) {
rect = a.getBoundingClientRect();
if ($.engine === 'webkit') {
if (rect.top < 0) {
d.body.scrollTop += rect.top - 42;
}
if (rect.left < 0) {
d.body.scrollLeft += rect.left;
}
} else {
if (rect.top < 0) {
d.documentElement.scrollTop += rect.top - 42;
}
if (rect.left < 0) {
d.documentElement.scrollLeft += rect.left;
if (rect.bottom > 0) {
if ($.engine === 'webkit') {
if (rect.top < 0) {
d.body.scrollTop += rect.top - 42;
}
if (rect.left < 0) {
d.body.scrollLeft += rect.left;
}
} else {
if (rect.top < 0) {
d.documentElement.scrollTop += rect.top - 42;
}
if (rect.left < 0) {
d.documentElement.scrollLeft += rect.left;
}
}
}
return ImageExpand.contract(thumb);

15
script.coffee
View File

@ -4116,12 +4116,15 @@ ImageExpand =
thumb = a.firstChild
if thumb.hidden
rect = a.getBoundingClientRect()
if $.engine is 'webkit'
d.body.scrollTop += rect.top - 42 if rect.top < 0
d.body.scrollLeft += rect.left if rect.left < 0
else
d.documentElement.scrollTop += rect.top - 42 if rect.top < 0
d.documentElement.scrollLeft += rect.left if rect.left < 0
if rect.bottom > 0 # should be at least partially visible.
# Scroll back to the thumbnail when contracting the image
# to avoid being left miles away from the relevant post.
if $.engine is 'webkit'
d.body.scrollTop += rect.top - 42 if rect.top < 0
d.body.scrollLeft += rect.left if rect.left < 0
else
d.documentElement.scrollTop += rect.top - 42 if rect.top < 0
d.documentElement.scrollLeft += rect.left if rect.left < 0
ImageExpand.contract thumb
else
ImageExpand.expand thumb