From 1951bcbe90483d2b356a80f66d9dde608f272e43 Mon Sep 17 00:00:00 2001 From: James Campos Date: Sat, 8 May 2010 01:21:50 -0700 Subject: [PATCH] fix movement on opera, optimize tag() why did I do both of these in one commit --- 4chan_x/4chan_x.coffee | 7 +++---- 4chan_x/4chan_x.js | 8 +++----- foltor/foltor.coffee | 10 ++++------ foltor/foltor.js | 12 ++++-------- 4 files changed, 14 insertions(+), 23 deletions(-) diff --git a/4chan_x/4chan_x.coffee b/4chan_x/4chan_x.coffee index 4d793f499..7f93ecce5 100644 --- a/4chan_x/4chan_x.coffee +++ b/4chan_x/4chan_x.coffee @@ -35,8 +35,7 @@ inBefore: (root, el) -> root.parentNode.insertBefore(el, root) inAfter: (root, el) -> root.parentNode.insertBefore(el, root.nextSibling) -tag: (el) -> - document.createElement(el) +tag: document.createElement hide: (el) -> el.style.display = 'none' show: (el) -> @@ -234,8 +233,8 @@ options: -> mousedown: (e) -> div: this.parentNode move.div: div - move.divX: div.offsetLeft - move.divY: div.offsetTop + move.divX: parseInt(div.style.left) + move.divY: parseInt(div.style.top) move.clientX: e.clientX move.clientY: e.clientY move.bodyX: document.body.clientWidth diff --git a/4chan_x/4chan_x.js b/4chan_x/4chan_x.js index c9b3e6a4e..369926ef0 100644 --- a/4chan_x/4chan_x.js +++ b/4chan_x/4chan_x.js @@ -47,9 +47,7 @@ inAfter = function inAfter(root, el) { return root.parentNode.insertBefore(el, root.nextSibling); }; - tag = function tag(el) { - return document.createElement(el); - }; + tag = document.createElement; hide = function hide(el) { el.style.display = 'none'; return el.style.display; @@ -272,8 +270,8 @@ cursor: pointer; \ var div; div = this.parentNode; move.div = div; - move.divX = div.offsetLeft; - move.divY = div.offsetTop; + move.divX = parseInt(div.style.left); + move.divY = parseInt(div.style.top); move.clientX = e.clientX; move.clientY = e.clientY; move.bodyX = document.body.clientWidth; diff --git a/foltor/foltor.coffee b/foltor/foltor.coffee index be9f3bb18..0463476a5 100644 --- a/foltor/foltor.coffee +++ b/foltor/foltor.coffee @@ -13,10 +13,8 @@ $$: (selector, root) -> node for node in result inBefore: (root, el) -> root.parentNode.insertBefore(el, root) -tag: (el) -> - document.createElement(el) -text: (s) -> - document.createTextNode(s) +tag: document.createElement +text: document.createTextNode remove: (root) -> root.parentNode.removeChild(root) position: (el) -> @@ -34,8 +32,8 @@ move: {} mousedown: (e) -> div: this.parentNode move.div: div - move.divX: div.offsetLeft - move.divY: div.offsetTop + move.divX: parseInt(div.style.left) + move.divY: parseInt(div.style.top) move.clientX: e.clientX move.clientY: e.clientY move.bodyX: document.body.clientWidth diff --git a/foltor/foltor.js b/foltor/foltor.js index dd96ad12b..60fde2eaa 100644 --- a/foltor/foltor.js +++ b/foltor/foltor.js @@ -24,12 +24,8 @@ inBefore = function inBefore(root, el) { return root.parentNode.insertBefore(el, root); }; - tag = function tag(el) { - return document.createElement(el); - }; - text = function text(s) { - return document.createTextNode(s); - }; + tag = document.createElement; + text = document.createTextNode; remove = function remove(root) { return root.parentNode.removeChild(root); }; @@ -50,8 +46,8 @@ var div; div = this.parentNode; move.div = div; - move.divX = div.offsetLeft; - move.divY = div.offsetTop; + move.divX = parseInt(div.style.left); + move.divY = parseInt(div.style.top); move.clientX = e.clientX; move.clientY = e.clientY; move.bodyX = document.body.clientWidth;