Goyslop/4chan-x
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cleaner PostClone constructor workaround

Browse Source
This commit is contained in:
Tuxedo Takodachi 2023-03-19 12:49:50 +01:00
parent 8f52b8be52
commit 06a72ee79b
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/classes/Post.js
View File

@ -5,12 +5,6 @@ import $ from "../platform/$";
import $$ from "../platform/$$"; import $$ from "../platform/$$";
import Callbacks from "./Callbacks"; import Callbacks from "./Callbacks";
/**
* Original coffeescript version added a child class that somehow skips the original constructor in the compilation
* output? In es classes we have to do tha manually.
*/
const skipConstructor = Symbol('skip post constructor');
/* /*
* decaffeinate suggestions: * decaffeinate suggestions:
* DS102: Remove unnecessary code created because of implicit returns * DS102: Remove unnecessary code created because of implicit returns
@ -34,7 +28,8 @@ export default class Post {
// @normalizedOriginal = Test.normalize root // @normalizedOriginal = Test.normalize root
// <% } %> // <% } %>
if (root === skipConstructor) return; // Skip initialization for PostClone
if (root === undefined && thread === undefined && board === undefined) return;
this.root = root; this.root = root;
this.thread = thread; this.thread = thread;
@ -355,7 +350,7 @@ export default class Post {
addClone(context, contractThumb) { addClone(context, contractThumb) {
// Callbacks may not have been run yet due to anti-browser-lock delay in Main.callbackNodesDB. // Callbacks may not have been run yet due to anti-browser-lock delay in Main.callbackNodesDB.
Callbacks.Post.execute(this); Callbacks.Post.execute(this);
return new PostClone(skipConstructor).construct(this, context, contractThumb); return new PostClone(this, context, contractThumb);
} }
rmClone(index) { rmClone(index) {
@ -377,12 +372,10 @@ export default class Post {
export class PostClone extends Post { export class PostClone extends Post {
static suffix = 0; static suffix = 0;
constructor(root, thread, board, flags = {}) { constructor(origin, context, contractThumb) {
super(root, thread, board, flags = {}); super();
this.isClone = true; this.isClone = true;
}
construct(origin, context, contractThumb) {
let file, fileRoots, key; let file, fileRoots, key;
this.origin = origin; this.origin = origin;
this.context = context; this.context = context;